search

sqlectron / sqlectron-core

https://sqlectron.github.io/
MIT License
221 stars 69 forks source link

Bump sqlite3 to 4.0.2 so build succeeds with node 10 #56

Closed armarti closed 4 years ago

armarti commented 6 years ago

It's impossible to build sqlite3 on node>=10 due to this:

The problem here is that V8 has removed ForceSet method in the V8 version that Node 10 uses, which in turn is what the nan module uses. nan has not yet caught up to the breaking changes in V8.

maxcnunes commented 5 years ago

Hi @armarti thanks for the PR. You removed although the production dependency to sqlite and kept only the devDependency. Could you please include back the production one? Also, are you sure the major change version doesn't have any breaking changes?

MasterOdin commented 4 years ago

Handled as part of 2b0e5516d9d3736dfa9e860f1e6a16945c6ddc15

The 4.x release was due to dropping support for node v0.10 and v0.12, and there was no breaking changes in the 4.x line from 3.x.