search

sqlfluff / sqlfluff-github-actions

The official resource for SQLFluff related GitHub Actions
MIT License
100 stars 37 forks source link

Add a working version of a GitHub action #1

Closed clrcrl closed 3 years ago

clrcrl commented 3 years ago

Note: this was me poking around in the dark. I don't know what GitHub Action best practices are, so am very open to feedback!

pwildenhain commented 3 years ago

@nolanbconaway can you give this a review 👀

nolanbconaway commented 3 years ago

😆 love the confidence that I know how to write a working github action. I think about two things:

  1. How to we reasonably handle version updates? 0.4.0 is right around the corner, is this a manual increment situation?
  2. It would be super super super cool for the action to be set up similarly to the one black has. I do not know exactly what sorcery goes into that (i think someone has to write a dockerfile?) but would be pretty ding darn cool.

Otherwise LGTM y'all lets ship it

clrcrl commented 3 years ago

@dmateusp — wanted to give you a heads up, this was my first attempt at writing a GitHub action, and I'm by no means attached to it! Happy for you to close this if you want to iterate on it yourself rather than wait on me (I'll be afk for the next two weeks — if I can manage it)

NiallRees commented 3 years ago

As there have been no additional comments, I'm going to merge as a good first step. Thanks @clrcrl !