Closed WittierDinosaur closed 1 month ago
Fixes #5844 The comparison was previously ignoring array accessors, and just comparing the column reference
No
[x] Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
test/fixtures/rules/std_rule_cases
.sql
test/fixtures/dialects
tox -e generate-fixture-yml
test/fixtures/linter/autofix
Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.
Name Stmts Miss Cover Missing ------------------------------------- TOTAL 17731 0 100% 225 files skipped due to complete coverage.
coverage: 99.985%. remained the same when pulling 9453375cf6a7e05e40d6dfcbd13e5ee80c128c9e on bugfix-5844 into d48ded5606e564990de135879f00b3932670f45f on main.
Brief summary of the change made
Fixes #5844 The comparison was previously ignoring array accessors, and just comparing the column reference
Are there any other side effects of this change that we should be aware of?
No
Pull Request checklist
[x] Please confirm you have completed any of the necessary steps below.
Included test cases to demonstrate any code changes, which may be one or more of the following:
.yml
rule test cases intest/fixtures/rules/std_rule_cases
..sql
/.yml
parser test cases intest/fixtures/dialects
(note YML files can be auto generated withtox -e generate-fixture-yml
).test/fixtures/linter/autofix
.Added appropriate documentation for the change.
Created GitHub issues for any relevant followup/future enhancements if appropriate.