Fix for issue #592, json query fix when question mark is used in data

sqlkata / querybuilder

SQL query builder, written in c#, helps you build complex queries easily, supports SqlServer, MySql, PostgreSql, Oracle, Sqlite and Firebird

https://sqlkata.com

MIT License

3.08k stars 498 forks source link

Fix for issue #592, json query fix when question mark is used in data #628

Open kamisoft-fr opened 1 year ago

kamisoft-fr commented 1 year ago

Fix places where the parameterPlaceholder is hardcoded to a question mark ?

Since the SqlResult still contained ToString method which had the hardcoded placeholder, here is what I've done:

1) Added compiler to the constructor of SqlResult 2) Made ParameterPlaceholder public 3) Added tests PostgresJsonTests

There is so a breaking change on the SqlResult class since its public, So the sqlkata version would be changed as major (2 to 3 or 3 to 4)

aastovas commented 1 year ago

Any update on this PR? It would be great if we could have it merged :)

hookenful commented 1 year ago

I highly upvote this

ghost commented 11 months ago

👇 Click on the image for a new way to code review

#### [![Review these changes using an interactive CodeSee Map](https://s3.us-east-2.amazonaws.com/maps.codesee.io/images/github/sqlkata/querybuilder/628/11fe28ed/8c396784293ac3f8bc18f407ad128893449a8f97.svg)](https://app.codesee.io/r/reviews?pr=628&src=https%3A%2F%2Fgithub.com%2Fsqlkata%2Fquerybuilder) #### Legend CodeSee Map legend