Add sidebar component - Githubissues

sqlpage / SQLPage

Fast SQL-only data application builder. Automatically build a UI on top of SQL queries.

https://sql.datapage.app

MIT License

1.57k stars 89 forks source link

Add sidebar component #509

Closed Ajotah98 closed 2 months ago

Ajotah98 commented 2 months ago

I updated the component "Sidebar" started on March.

Ajotah98 commented 2 months ago

Cool, thank you very much for the PR ! I want to get it through the finish line ! Can you have a look at my comment above, and revert the indentation changes ?

Sorry! I was busy. I'll update it asap and review the comment. Thanks!

Ajotah98 commented 2 months ago

Hi! I was seeing the changes you have done and I really think... That is all done for now? I don't know if you want to implement more things onto the sidebar

lovasoa commented 2 months ago

As I said, I'm a little bit hesitant of duplicating the logic of parsing and iterating over the menu items. Is there any chance you can factor it in order to have the same markup for the horizontal and vertical bars, with only classes differing?

lovasoa commented 2 months ago

I think this is ready :) Can you please resolve the conflicts so I can merge ?

lovasoa commented 2 months ago

The conflicts probably come from the changes made here to fix the elision of long titles:

https://github.com/lovasoa/SQLpage/commit/6cc4cce73c1ac67dac3d18b932ab30983a11b933#diff-255998f398cb0bb6096065f84876aea7a2ca35ba2c6dda8162e4195e2654ee94

Ajotah98 commented 2 months ago

Okey, I was seeking whats causing merge conflicts, and testing the actual menu-items from the commit you posted, and:

With this new approach, the sidebar menu items get aligned into the right as you can see in the image.

I'll check how can I make if it's on sidebar, apply another CSS styles to make the layout more flex

Ajotah98 commented 2 months ago

I'm more convinced that the conflicts are now solved. The conflicts showed on the branch are a white-space that no longer exists on the component and the addition of the inline of menu-items.

What are your thoughts about this @lovasoa ?

lovasoa commented 2 months ago

You can merge the main branch of this repo into your branch, then, and the conflicts will disappear here

Ajotah98 commented 2 months ago

Cool, it worked. Thanks!

lovasoa commented 2 months ago

Great, here we are! Thank you!

lovasoa commented 2 months ago

Argh, I think this broke the menu layout on narrow screens :/

before

after

lovasoa commented 2 months ago

Also there is now an underline on the page title on hover

Ajotah98 commented 2 months ago

I'm going to check the CSS. Sorry for the inconvenience

Ajotah98 commented 2 months ago

Also there is now an underline on the page title on hover

This behaviour occurs in v.0.26.0. Is not a modification on the sidebar addition :/

lovasoa commented 2 months ago

Thank you ! No problem. You can have a look at the mobile layout problem, and I'll take care of the underline, then !

Ajotah98 commented 2 months ago

I found the problem! I'll try to fix it ASAP

lovasoa commented 2 months ago

I'm updating the https://sql.ophir.dev/examples/layouts.sql page to demonstrate the new sidebar