sqlpage / SQLPage

Fast SQL-only data application builder. Automatically build a UI on top of SQL queries.
https://sql.datapage.app
MIT License
1.65k stars 98 forks source link

"search_target" functionality missing in Shell component in v0.29.0 #621

Closed lovasoa closed 1 month ago

lovasoa commented 2 months ago

Description: Version 0.29.0 does not implement the "search_target" functionality in the Shell component. The search field and button are not displayed.

Steps to Reproduce:

  1. Install or update to version 0.29.0 of SQLPage.

  2. Attempt to use the Shell component with the "search_target" functionality.

Expected Behavior: The search field and button should appear as they do in version 0.28.0.

Actual Behavior: The search field and button are missing in version 0.29.0.

Workaround: Reverting to version 0.28.0 restores the functionality.

Environment:

SQLPage version: 0.29.0

Tested with rollback to version 0.28.0 where the feature works correctly.

Additional Context: No other issues observed with the rollback.

lovasoa commented 2 months ago

This is due to SQLPage not displaying the menu at all when no menu_item is present. The current best workaround is to simply include a menu.

select 'shell' as component,
    'home' as menu_item,
    '/' as search_target,
    'It works !' as search_value;

works, but :

select 'shell' as component,
    '/' as search_target,
    'error' as search_value;

fails