Closed christophercook closed 8 years ago
I'll take a look and update accordingly.
Thanks! Definitely a valid test to check for.
Very interested into this as it's making it a show stopper. It's been a while since I did C, code looks clear and I might give it a try but really a bit of out of time, any idea if you were able to look at this at all or whether you think the change is too wide or just local?
Thanks.
Bug confirmed with cyrillic characters in 0.1.1
Here is an example:
--TEST-- Strings containing cyrillic characters --FILE-- <?php $js = <<<JS var test="тест"; JS; echo jsmin($js); --EXPECT-- var test="тест";
Any news on that? Since I haven't used c for too log, I guess I can't help on that, but maybe this helps: http://www.cprogramming.com/tutorial/unicode.html
good news! #40 is now working, waiting to be merged! :)
Working on new release now.
Tagged as 2.0.0. Pushed release to PECL. Thanks @c9s
The following test will fail because jsmin() returns spaces (or other hidden character) where multibyte characters were originally. The original Jsmin claims to handle UTF-8 so I expected it to work here also.
--TEST-- Strings containing extended characters --FILE-- <?php $js = <<<JS var test="février"; JS; echo jsmin($js); --EXPECT-- var test="février";
Using PHP 5.3.10 (on Ubuntu server) with a UTF-8 encoded php file I get: var test="f vrier";