search

sqmk / pecl-jsmin

PHP PECL extension for JavaScript minification
Other
69 stars 21 forks source link

Updated JSMin.c #18

Closed jwhitcraft closed 11 years ago

jwhitcraft commented 11 years ago

This was not compiling with the php 5.3 and what not, I've just updated the jsmin.c from the main JSMin repo.

sqmk commented 11 years ago

Hey Jon,

I can update the travis config to test against PHP 5.3.26.

Unfortunately, I can not merge this pull request. Copying Crockford's latest changes to jsmin.c verbatim requires much more work. Check out your diff and you'll notice you have removed some code that is necessary to work with PHP's API. The changes are also reporting the build as a failure.

I can copy Crockford's changes over and rerun the tests.

jwhitcraft commented 11 years ago

@sqmk, thanks for looking into to it. Let me know if there is anything I can do to fix it. My C skills are a bit rusty but I'm willing to help.

sqmk commented 11 years ago

No worries :-)

Say hello to Uriah and Majed for me (assuming you are still at Sugar)!

jwhitcraft commented 11 years ago

@sqmk, I got it updated with the latest JSMin. Let me know what you think.

sqmk commented 11 years ago

Thanks @jwhitcraft, I'll check this out.

sqmk commented 11 years ago

Looks like the current build minus your changes works on latest PHP 5.3 and PHP 5.4, so I'm a bit lost on where it fails compiling.

Your request look good with the exception of some indentation, but I am happy to pull it in and fix up the spacing issues. I'll spend some time in the morning and pop in your changes.

jwhitcraft commented 11 years ago

@sqmk,

Here is the error I'm getting when i compile your master repo

/Users/jwhitcraft/Projects/pecl-jsmin/jsmin.c:133:6: error: non-void function 'jsmin_next' should
      return a value [-Wreturn-type]
                                        return;
                                        ^
1 warning and 1 error generated.
make: *** [jsmin.lo] Error 1