search

sqmk / pecl-jsmin

PHP PECL extension for JavaScript minification
Other
69 stars 21 forks source link

Utf8 support #40

Closed c9s closed 8 years ago

c9s commented 8 years ago

This is a WIP PR

See also: http://www.cprogramming.com/tutorial/unicode.html

Related issue: #35 #14

c9s commented 8 years ago

Good news! the utf8 test cases are passed! @sqmk

arnested commented 8 years ago

:+1:

sqmk commented 8 years ago

Looking good. Merging and I'll tag and release v2.0.0 via PECL.

sqmk commented 8 years ago

Might be helpful if I merged the PR before closing this :-P

osopolar commented 8 years ago

Coming from an issue in a drupal contrib module (https://www.drupal.org/node/2566311), I can confirm that this solves the issue. Thanks c9s for your great job and sqmk for the new release.

osopolar commented 8 years ago

@c9s Could the UTF8 implementation be responsible for some illegal characters at the end of the minified string (see issue #46)?