search

sqmk / pecl-jsmin

PHP PECL extension for JavaScript minification
Other
69 stars 21 forks source link

Issue #51: feature/php7 now compiles under FreeBSD #52

Closed RafalLukawiecki closed 6 years ago

RafalLukawiecki commented 7 years ago

Simple change to avoid including a non-existent (and unnecessary) library under FreeBSD. I have only updated the feature/php7 branch.

sqmk commented 7 years ago

I'll take a look at this shortly and merge in if everything looks ok.

pesc commented 6 years ago

@sqmk Is there an issue or just the lack of time why you're not accepting the pull request? Thank you! :+1:

RafalLukawiecki commented 6 years ago

For what it’s worth, I’ve been using the patched version (ie the one patiently waiting for the PR to be merged) in production on FreeBSD servers running PHP7 for 3 months without issues.

RafalLukawiecki commented 6 years ago

Thank you, @sqmk, for merging.

pesc commented 6 years ago

@sqmk Thanks for that Michael and thank you @RafalLukawiecki !