sqrl-lang / sqrl

A safe, stateful rules language for event streams
Apache License 2.0
113 stars 11 forks source link

Added a route for health check #26

Closed nagn closed 1 year ago

nagn commented 1 year ago

Problem

In Kubernetes running docker containers typically need a readiness and health checks to make sure the container is running/ready

Solution

Describe the modifications you've done. Added a path for /health that just returns 200 so the container can run in K8s.

Result

This will always return a passing health check so long as its running. Note that to truly follow k8s semantics we would probably want a seperate readiness check to pass (for instance once we've established a connection to redis), versus liveness which just checks that the service is alive. LMK if this is important enough to revise

nagn commented 1 year ago

@qix updated the PR with your suggested changes

nagn commented 1 year ago

@qix Mind approving/merging these changes? I don't seem to have permission here

nagn commented 1 year ago
Screen Shot 2022-12-09 at 10 10 44 AM
meyer commented 1 year ago

@nagn running now...

nagn commented 1 year ago

@meyer thanks for running the checks! You'll have to merge it since I don't have write access but I appreciate you taking a look!

meyer commented 1 year ago

🚢💨