Closed nagn closed 1 year ago
@qix updated the PR with your suggested changes
@qix Mind approving/merging these changes? I don't seem to have permission here
@nagn running now...
@meyer thanks for running the checks! You'll have to merge it since I don't have write access but I appreciate you taking a look!
🚢💨
Problem
In Kubernetes running docker containers typically need a readiness and health checks to make sure the container is running/ready
Solution
Describe the modifications you've done. Added a path for /health that just returns 200 so the container can run in K8s.
Result
This will always return a passing health check so long as its running. Note that to truly follow k8s semantics we would probably want a seperate readiness check to pass (for instance once we've established a connection to redis), versus liveness which just checks that the service is alive. LMK if this is important enough to revise