search

sqrl-planner / sqrl-client

Frontend web app for Sqrl Planner, a timetable planner for the University of Toronto.
https://sqrlplanner.com
MIT License
18 stars 7 forks source link

Lack of support for courses starting before 9am #95

Open ngaionice opened 2 years ago

ngaionice commented 2 years ago

Describe the bug Currently the timetable UI does not display courses that start before 9am.

To Reproduce Steps to reproduce the behavior:

  1. Select/hover over GER100Y1 LEC 0401, or CHM249 PRA 0101/0201

Expected behavior A time 'block' shows up on the timetable when selected/hovered over.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information): Chrome v103

Additional context Shouldn't be difficult to fix from my POV, seems like the row for 8am classes just need to be added and things should work fine.

eamonma commented 2 years ago

Ah, thanks for the notice. Currently a workaround is to just manually set the timing in the prefs image, but for the future we certainly want to automatically set the time bounds for the timetable. For that, I'm thinking going through a course's section list and checking if there's a section that exceeds either time bound; if there is, we resize it on sidebar selection. The alternative is to resize on hover for a section that exceeds the bounds, but that will cause flashing and I don't think we'd prefer it. Thoughts @galacticglum?

galacticglum commented 2 years ago

We can resize it on add (so sidebar selection)? And for hover, what about a toast?

eamonma commented 2 years ago

We can resize it on add (so sidebar selection)? And for hover, what about a toast?

Sidebar selection as in a course is selected in the sidebar, not necessarily a section is picked. This way we maintain functionality transparently; I think toast is too clunky for this.