search

sqrldev / wordpress-sqrl-login

SQRL Login WordPress plugin
MIT License
21 stars 7 forks source link

chore(README): Explain screenshots (#41) #44

Closed sesam closed 4 years ago

sesam commented 4 years ago

Issue #. Adresses #41

Changes: Adds an initial explanation of the included screenshots.

sesam commented 4 years ago

Good catch @alexhauser! I fixed it using the Github code change suggestion feature, now I see it made one commit each for those things, so I suggest a Squash-merge rather than normal merge once this is approved.

alexhauser commented 4 years ago

@sesam,

I'm not a native English speaker, so bear with me if I'm mistaken here, but to me this still seems wrong:

... before having enabled SQRL for log in.

To me, it seems it should either be

... before having enabled SQRL for login. or ... before having enabled SQRL for logging in.

After all, as a verb is's "to log in", but the noun for the procedure is "the login".

sesam commented 4 years ago

Thank you @alexhauser - two occurences of this "Swenglish" fixed. Keep the fix requests coming :)