search

sqrldev / wordpress-sqrl-login

SQRL Login WordPress plugin
MIT License
21 stars 7 forks source link

PHP 8 notice to warning issue #65

Closed miquelfire closed 1 year ago

miquelfire commented 1 year ago

Issue #. Could be related to #64

Description: Fixes an issue in which prevents someone from logging in because of changes with PHP 8 handling errors.

Root cause, if a key is undefined, PHP before 8.0 would treat this as a notice, and notices by default were hidden. PHP 8 upgraded this to a warning, so even if someone switched error_reporting to PHP 7.x days, these two if statements would still print out an error on successful logins about an undefined key.

Fixes https://sqrl.grc.com/threads/php-version-support.1261/

Changes: Surround the error handling with an if statement that checks if the err key is set before checking the value.

kalaspuffar commented 1 year ago

Great catch. Thank you @miquelfire