search

squ1b3r / Djaneiro

Django support for Sublime Text 2/3
MIT License
855 stars 131 forks source link

Default to single instead of double quotes #117

Closed w- closed 7 years ago

w- commented 7 years ago

Static tag is typically used to get the url of static assets for use in tags like img, script and link. Defaulting to double quotes screws up syntax highlighting for editors because the default delimiter in html is the double quote.

squ1b3r commented 7 years ago

Hey, thanks for the pull request. Unfortunately, I cannot accept this. Changing only this one will make things inconsistent as everything else uses double quotes.

There are a lot of users who've been using Djaneiro for years and this would be a big surprise for them.

Besides, I don't really see the point. What are those editors you are referring to? ST3 handles cases like this with no problem. PyCharm, for example, doesn't have any issues with this either.

w- commented 7 years ago

ST3 handles cases like this with no problem

Hmm... interesting. I'm using ST3 and is the reason I submitted this. It handles this case out of the box? Because on my end it doesn't. (light green/blue/teal here indicates an html tag attribute) image

squ1b3r commented 7 years ago

This is intentional to make arguments of Django tags and filters more readable.