search

squ1b3r / Djaneiro

Django support for Sublime Text 2/3
MIT License
855 stars 131 forks source link

Switch to a sublime-syntax based syntax definition. #123

Closed willstott101 closed 4 years ago

willstott101 commented 4 years ago

This is work I've been doing at https://github.com/willstott101/django-sublime-syntax

I've deliberately not changed the colour of most built-in template tags as I don't think it adds to readability. I coloured most template tags as function calls, rather than keywords, as html tags are coloured like keywords so I found it hard to differentiate.

Before: Screenshot from 2019-12-06 12-33-34

After: Screenshot from 2019-12-06 12-29-55

willstott101 commented 4 years ago

You'll have to enable github actions to get the tests, but they're passing on my fork

squ1b3r commented 4 years ago

@willstott101 Thanks a ton for your contribution and all the work. Going to review this over the weekend.

squ1b3r commented 4 years ago

@willstott101 Been busy this week so it will take a little longer, sorry. I also am thinking about making a separate branch for this so that I can merge and test, and then remove old syntax file and to avoid these changes getting to people before it's ready. Thoughts?

willstott101 commented 4 years ago

I would be happy for this to merged into a separate branch if you would like to add to you it yourself. I could also give you commit access to my fork if you'd like to keep the single PR with it's diff intact.

squ1b3r commented 4 years ago

Created syntax-refactoring branch for these changes.

willstott101 commented 4 years ago

I've moved the PR to that branch