squ1b3r / Djaneiro

Django support for Sublime Text 2/3
MIT License
855 stars 131 forks source link

Fix id highlighting issue #86

Closed ethanal closed 9 years ago

ethanal commented 9 years ago

It looks like the problem I reported in issue #69 was caused by a pattern that was meant to highlight the HTML id attribute a different color than other attributes. It was not related to invalid XHTML or attribute minimization. This pull request resolves this issue by removing the special highlighting of the HTML id attribute, which I don't think would be problematic because it seems most color schemes don't color the id attribute differently any way.

squ1b3r commented 9 years ago

Sorry, but I'm not going to remove a piece of default behaviour to solve a non-existing issue. There is no problem with highlighting if HTML is correct. Besides I'm going to rewrite HTML (Djaneiro) syntax file to utilize inheritance and there won't be all that syntax definition from original HTML file means there won't be a way to remove this anyway.