search

squadracorsepolito / jsondbc

JSON to dbc converter
MIT License
3 stars 1 forks source link

GenMsgSendType enum values #14

Closed kelvincesar closed 2 months ago

kelvincesar commented 2 months ago

Hello!

Do you guys know if there is a standard on GenMsgSendType values to be always PascalCase?

https://github.com/squadracorsepolito/jsondbc/blob/606572c682f5ecc2deafffad9a83d6fd3a7d8a30/pkg/sym/attributes.go#L12

Because I had some errors in some generated DBC file from Vector, where the "Cyclic" was generated as "cyclic". Also I didn't found any reference of how it should be.

I don't know if it would be a problem, but I thought in comparing it converting everything to lowercase on the following function:

https://github.com/squadracorsepolito/jsondbc/blob/606572c682f5ecc2deafffad9a83d6fd3a7d8a30/pkg/utils.go#L99

Thanks! Kelvin Andrade

FerroO2000 commented 2 months ago

Hi, we have used PascalCase because it was the case in our .dbc files. Btw, in v0.5.3, I have changed the function checkCustomEnumAttribute and now it is NOT case sensitive

Thanks for reporting this issue

kelvincesar commented 2 months ago

Nice, thank you!