search

squalou / google-chat-linux

source of a fork of google-chat-linux unofficial client from robyf
50 stars 10 forks source link

FIX: Systray left click & display on Wayland. Main window handling #54

Closed SippieCup closed 2 years ago

SippieCup commented 2 years ago

Three broken behaviors were addressed in this commit.

  1. Fixes systray not appearing on wayland systems due to incorrect resource paths when building a stand alone application. Icon resources have been added to the electron builder configuration to be packaged with the app and paths.js updated accordingly.

BREAKING CHANGE: Before this fix, systray worked with npm start or electron . when developing. Now it will only work once the application has been packed. Can be refactored to detect its environment and determine the correct path.

  1. Fixes left click functionality for the systray by updating the electron wrapper and removing the libappindicator-* stub hack. Systray clicking and context menu now work as intended.

  2. Fixes main window management to be responsive to GTK3 widget manipulation such as i3/sway kill window by updating electron wrapper.

Additional Chores:

  1. Removed fs stub package and path from npm dependencies, both are core modules of Node.js and present an opportunity for package hijacking.

  2. Removed package electron-localshortcut, unused package.

  3. Bump electron-context-menu version. Fixes compatibity with latest electron wrapper.

  4. Specified latest LTS node engine in package.json for better visibility into development.

  5. Version bumped to 5.20.18-1

Closes #53

squalou commented 2 years ago

@SippieCup once again thank you !