search

squalou / google-chat-linux

source of a fork of google-chat-linux unofficial client from robyf
50 stars 10 forks source link

Custom CSS #73

Closed ThatOneCalculator closed 10 months ago

ThatOneCalculator commented 10 months ago

Re-addresses #62 , even though theming isn't the nicest with the current Google Chat version, it's still possible.

Also migrates the lockfile to v3 for speed and compatibility

squalou commented 10 months ago

Amazing ! thanks, will merge it asap

quick test showed this :

image

which is weird considering the try catch.

Maybe crating an empty file would be fine, and it would guide users that never read docs :)

ThatOneCalculator commented 10 months ago

Just woke up, I'll do that a bit later today 👍

ThatOneCalculator commented 10 months ago

@squalou should be good now

squalou commented 10 months ago

looks much better ! thanks

Merging it, release asap

squalou commented 10 months ago

OMG I should have tested more, maybe due to my connexion (holiday \o/) or electron : clicking on people or rooms does not display them :-)

I don't know if you can reproduce, will try to debug it, maybe it's local to my setup

(I really think it's due to my connexion, it's a real nightmare here, will check again tomorrow, with patience it looks fine in the end)

ThatOneCalculator commented 10 months ago

That's really strange... I can't reproduce that issue at all. At least not with the Electron version that was used while writing this PR (I saw you upgraded it after)

squalou commented 10 months ago

release done :)