squalou / google-chat-linux

source of a fork of google-chat-linux unofficial client from robyf
50 stars 10 forks source link

Move the "Apply theme" option to an app-specific Preference window #8

Closed Deuchnord closed 3 years ago

Deuchnord commented 4 years ago

The new option "Apply theme" is placed on top of the indicator menu. That’s quite annoying, because sometimes, I misclick it when I actually want to show the window. Since this option is configuration-related, it would be great if this option were moved to a new app Preference window.

squalou commented 4 years ago

I understand, and beeing a total noob at UX design I value this feedback.

I'll see how to improve it (hopefully shortly)

in the meantime, note that left click on the systray icon DOES show the window (no need to right click / Show). So, it's a kind of workaround.

(and the 'X' of the main window does hide it, in case right click in tray / hide is cumbersome too)

thing is, there's no really "app" space, it's just the google chat window being displayed in a browser. The only specific space is the systray menu. Maybe I'll have to add a menu or something in he main app, which would use space. Not sure what is best.

squalou commented 4 years ago

Right now, I've changed the order of items, and added a separator

apply theme
--------------
force reload
show/hide
quit

Should help prevent missclick

Deuchnord commented 4 years ago

in the meantime, note that left click on the systray icon DOES show the window (no need to right click / Show). So, it's a kind of workaround.

Actually, it does not on GNOME Shell, but it’s not related to your app (on GNOME, left click does not exist on indicators). It shows the menu instead.

thing is, there's no really "app" space, it's just the google chat window being displayed in a browser. The only specific space is the systray menu. Maybe I'll have to add a menu or something in he main app, which would use space. Not sure what is best.

Yes, but Google Chat for Linux acts exactly like an application. so you can perfectly add your own window that would take care of user preferences :)

Right now, I've changed the order of items, and added a separator

apply theme
--------------
force reload
show/hide
quit

Should help prevent missclick

In my opinion, the items should be ordered in a way that the most used one is at the first place, and the less used one is at the lat place. So a more logical order would be:

  1. Show/Hide
  2. Force reload
  3. Apply theme
  4. (separator)
  5. Quit
squalou commented 4 years ago

Didn't know for Gnome. I have friends using Gnome I'll try to test with them next time. From what I remember you had to add an extension on Gnome to have systray displayed, is it still the case ?

Not everyone uses the same menu entries, except for Quit which is mandatory for everyone. (frankly I never use the other ones except when debugging)

So, no problem, I reorder this.

One last question for your Gnome display : assuming you have the 'gnome bar' on top of the screen, how does the systray display for now ? (what is on top, what on bottom)

On your example : 1. would be the top and 5. the bottom ?

PS : I will probably remove 'force reload' soon, I put it there when 'Ctrl K' froze the window

Deuchnord commented 4 years ago

It currently looks like this: Screenshot

squalou commented 4 years ago

I've set it like this, I hope it's finefor a quick fix. (finally, I leave the "force reload" ... in order to reload the 'hidden' window I've introduced to fix the systray color change, the reload may be needed when login back to the account )

image

Deuchnord commented 4 years ago

Perfect, thanks! :smile:

squalou commented 4 years ago

Small step : added a custom menu that duplicate the systray options.

Main goal : for OS where systray is not available ... or else Quit is impossible :)

squalou commented 3 years ago

won't fix anything more about that, to be honest.