squalou / google-chat-linux

source of a fork of google-chat-linux unofficial client from robyf
50 stars 10 forks source link

Remove Linux from name field of desktop file #81

Closed pbabinca closed 9 months ago

pbabinca commented 9 months ago

Before this change a .desktop file got name "Google Chat Linux". This name, which appears in Desktop environment menu or other places sounds strange when one already uses Linux and therefore 99% of apps are linux-based.

squalou commented 9 months ago

True, "Linux" does not make sense, but instead of removing it entirely, the name should be completed by something, and I'm bad at naming things so I never changed it.

Thing is : if you install PWA from a chrome-ish browser, it will be called Google Chat too, so it's confising. Same thing for the 'Tauri' app being developed : 'google chat' only in the name sounds too confusing.

So ... no real idea. Adding electron is ugly and too long.

In addition, for consistency, if the name get changed in desktop file, it should also be changed everywhere else, including the config file, and thus at application start both names should be checked for first run when migrating.

Not a big deal for sure once a good name is decided.

pbabinca commented 9 months ago

Ah, that makes sense. Then what about " Unofficial" one?

In addition, for consistency, if the name get changed in desktop file, it should also be changed everywhere else, including the config file, and thus at application start both names should be checked for first run when migrating.

This might be tricky for packages. Because new package should obsolete old one. I know how that can be done on rpm level - https://docs.fedoraproject.org/en-US/packaging-guidelines/#renaming-or-replacing-existing-packages but I'm not sure how/if it is possible to do so with electron-builder nor if it won't cause issues with debian packaging.

squalou commented 9 months ago

I didn't even think about packages, you're right.

Ok, let's just change the visible name.

Unofficial feels too long, Desktop is lame JS would have been cool 10 years ago :) NG 20 years ago β for the electron symbol but we'll hit languages issues :-) Google Chatium would be sort of a lie (even if some calls to google are filtered out) Lite would be an even bigger lie :)

still looking for something.

pbabinca commented 9 months ago

To that list - what about: "Google Chat Alt"?

Or slightly childish - "Google Chatty"?

squalou commented 9 months ago

What about + ? Google Chat +

short, and pun intended with - that also comes with e- electron symbol

Commented almost at the same time as you, was also thinking about Alt, which is not bad.

pbabinca commented 9 months ago

Whatever non-obvious name it will have I think description might help to explain what it means. I think regular users might not care about technology hidden behind the app so I wouldn't emphasize that. But that doesn't mean that there can't be hidden pun :).

As for the "Alternative" the description of the app could be then: "Unofficial alternative to access Google Chat"

With the plus sign I'm thinking of "Unofficial Google Chat client with added value"

squalou commented 9 months ago

The more I think about it, the more "Alt" seems right. Let's go for that.

Can you manage the description field too ? "Unofficial alternative Google Chat desktop app" (I hesitate with 'client' but the description should be really easy to understand, so, desktop app seems less techy)

From what I've just seen there is still "hangout" mentioned in the description, that's so old :)

squalou commented 9 months ago

thx !

squalou commented 9 months ago

I've tried hte rpm build action (did a tag :) )but it failed. Can you check the issue I opened ? I copied the logs there. No idea if you can see the actions of my repo or not.