search

square / Cleanse

Lightweight Swift Dependency Injection Framework
Other
1.78k stars 90 forks source link

add SwiftUI sample #176

Closed chathil closed 3 years ago

sebastianv1 commented 3 years ago

This is awesome! A couple things:

  1. Let's give you credit, go ahead and add an entry into the CHANGELOG.
  2. I don't see any tests in your sample project which is okay, but let's make sure your project continues compiling in the future with CI. Under .github/workflows/main.yml would you mind adding a new action to compile your sample project?
chathil commented 3 years ago

Okay will do. About the test, I'll create another PR next weekend.