square / Cleanse

Lightweight Swift Dependency Injection Framework
Other
1.79k stars 90 forks source link

Cleanse is broken in Swift 3.2 #59

Closed holmes closed 6 years ago

holmes commented 7 years ago

A few silly little warnings.

But the big issue is when declaring a Component that has a Seed of Void.

Now when calling componentFactory.build() we're getting

/work/Cleanse2/CleanseTests/ComponentVisitorTests.swift:29:41: Missing argument for parameter #1 in call

I've tried passing Void but then it says

/work/Cleanse2/CleanseTests/ComponentVisitorTests.swift:29:40: Argument passed to call that takes no arguments

We'll have to find the magic incantation.

holmes commented 7 years ago

Created a swift-3.2 branch for the changes.

Daemon-Devarshi commented 7 years ago

Any update on this issue?

holmes commented 7 years ago

No sorry, haven't had any time to look into it.

sebastianv1 commented 6 years ago

@holmes Resolve this one too. Should be fixed.