Swift 4.2 Support. - Githubissues

square / Cleanse

Lightweight Swift Dependency Injection Framework

Other

1.78k stars 90 forks source link

Swift 4.2 Support. #78

Closed sebastianv1 closed 6 years ago

sebastianv1 commented 6 years ago

The ImplicitlyUnwrappedOptional type was removed in swift v4.2 (https://github.com/apple/swift-evolution/blob/master/proposals/0212-compiler-version-directive.md).

holmes commented 6 years ago

LGTM, i'll let you merge

CodyDunlap commented 6 years ago

Will this be merged soon? XCode 10 dropped support for Swift 4.1 so we would like to upgrade to 4.2 but are waiting on Cleanse to support 4.2.

sebastianv1 commented 6 years ago

Yes we can merge. I just haven't gotten around to verifying a swift 4 target compiling Cleanse on XC 9 edge-case, but if that breaks I can push a fast-follow fix.

CodyDunlap commented 6 years ago

Thanks! I created a PR #80 to update the podspec so that this update also makes it into Cocoapods.