search

square / Cleanse

Lightweight Swift Dependency Injection Framework
Other
1.78k stars 90 forks source link

AppDelegate.injectProperties method declaration is not shown in the README #94

Closed HenriLangenhoven closed 5 years ago

HenriLangenhoven commented 5 years ago

The title pretty much sums it up.

I suspect the method declaration was meant to go after this section:

Note: Even though we can configure property injection with closures, it is generally cleaner to make a method that sets the properties like we did with AppDelegate.injectProperties:

HenriLangenhoven commented 5 years ago

Oh I see it is defined further down, but the syntax is a bit broken. It seems there needs to be a space after code-block::

.. code-block::swift func injectProperties(_ window: UIWindow) { self.window = window }

sebastianv1 commented 5 years ago

Ah thanks for calling that out. We did need a space after code-block:: and a newline. Putting up a PR now.