CONV-1435: Add scroll indicator insets to customScrollViewInsets - Githubissues

square / Listable

Declarative list views for iOS apps.

Apache License 2.0

204 stars 28 forks source link

CONV-1435: Add scroll indicator insets to customScrollViewInsets #500

Closed gilgtm closed 1 year ago

gilgtm commented 1 year ago

Before: customScrollViewInsets only returns insets to adjust contentInset
After: customScrollViewInsets function signature matches calculateScrollViewInsets so you can specify scroll-indicator insets
Why? In the chat demo, the scroll bar was disappearing below the bottom inset of the list. It's likely that if you are modifying contentInset you will have to modify scroll indicator insets as well

Before

https://github.com/square/Listable/assets/73715873/ef74979d-83fb-478d-a3df-0a33da9f6148

After

https://github.com/square/Listable/assets/73715873/f4e048b1-6904-4ffb-a5b1-e836e18caf5d

Checklist

Please do the following before merging:

[x] Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.