Don't animate when dequeuing cells

kyleve commented 12 months ago

EDIT: Reverted here https://github.com/square/Listable/pull/542

https://block.atlassian.net/browse/UI-5081

We now force a non-animated layout before dequeuing a cell, to ensure that any implicit animations that may occur are avoided. This avoids issues where you may see an animation as a reused cell's changed state is applied.

Checklist

Please do the following before merging:

[x] POS Integration Test
[x] Market Integration Test
[x] Ensure any public-facing changes are reflected in the changelog. Include them in the Main section.

kyleve commented 10 months ago

Seems reasonable, but this won't cause an extra layout, would it? it's just going to happen earlier and non-animated since the cell should be needsLayout = false after this?

I logged calls to layout and the number of calls seemed identical from what I could tell.

kyleve commented 10 months ago

This is for some reason breaking the KIF tests, seemingly related to market search bar, will need to dig into that before merging: https://square-console.sqprod.co/bbr/production/ci_jobs/PR+ios+WK-SK4+Bazel-Pipeline-PR/3

square / Listable

Don't animate when dequeuing cells #517

Checklist