search

square / PonyDebugger

Remote network and data debugging for your native iOS app using Chrome Developer Tools
Other
5.87k stars 595 forks source link

Bump PonyDebugger to use the lastest SocketRocket #200

Closed holmes closed 4 years ago

holmes commented 7 years ago

I don't really know what I'm doing here.

justinseanmartin commented 7 years ago

We should also bump the version of SocketRocket consumed by the podspec. The SocketRocket submodule reference bump will only work for consumers pulling in PonyDebugger as a submodule.

justinseanmartin commented 7 years ago

Looks like 0.5.1 is the latest. We should probably ensure that the version pulled from cocoapods and the one that the submodule reference SHA are the same as well.

justinseanmartin commented 7 years ago

Also do a PonyDebugger.podspec version bump

justinseanmartin commented 7 years ago

I take back my statement on CocoaPods, the podspec isn't restrictive to version of SocketRocket. LGTM.

holmes commented 7 years ago

Waiting on a new version of SocketRocket, see https://github.com/facebook/SocketRocket/issues/513

mthole-old commented 4 years ago

I think we can close this out. As part of https://github.com/square/PonyDebugger/pull/212, I updated to SocketRocket 0.5.1. That's the latest "release" available (see https://github.com/facebook/SocketRocket/releases).