square / anvil

A Kotlin compiler plugin to make dependency injection with Dagger 2 easier.
Apache License 2.0
1.31k stars 80 forks source link

always use `-Werror` in internal KCT compilations #945

Closed RBusarow closed 6 months ago

RBusarow commented 6 months ago

prompted by https://github.com/square/anvil/pull/934#discussion_r1544638830

Before this change, allWarningsAsErrors defaulted to false locally but true in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated.

Note that the public compileAnvil(...) function in our test fixtures (link) defaults to false, but now our internal compile(...) from TestUtils now defaults to true. That avoids a breaking change.