Before this change, allWarningsAsErrors defaulted to false locally but true in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated.
Note that the public compileAnvil(...) function in our test fixtures (link) defaults to false, but now our internal compile(...) from TestUtils now defaults to true. That avoids a breaking change.
prompted by https://github.com/square/anvil/pull/934#discussion_r1544638830
Before this change,
allWarningsAsErrors
defaulted tofalse
locally buttrue
in CI. We don't really gain anything by ignoring those warnings locally, since the relevant code is so isolated.Note that the public
compileAnvil(...)
function in our test fixtures (link) defaults tofalse
, but now our internalcompile(...)
fromTestUtils
now defaults totrue
. That avoids a breaking change.