search

square / assertj-android

A set of AssertJ helpers geared toward testing Android.
https://square.github.io/assertj-android/
Apache License 2.0
1.58k stars 156 forks source link

Add Convenience Methods For Orientations #11

Closed f2prateek closed 11 years ago

f2prateek commented 11 years ago

https://github.com/square/fest-android/issues/5 : Adds isVertical() and isHorizontal() for LinearLayout and GridLayout

JakeWharton commented 11 years ago

Can you drop the this's? Otherwise looks great!

f2prateek commented 11 years ago

patched :)

JakeWharton commented 11 years ago

Er, sorry there's one more thing. We use two space indents, no tabs. Not sure why checkstyle didn't fail on that...

f2prateek commented 11 years ago

The first commit had two space indents, but checkstyle failed that one - maybe I'll use vim instead of IntelliJ to fix this.

f2prateek commented 11 years ago

Hopefully this is good to go :)

JakeWharton commented 11 years ago

Thanks! (We're picky)

f2prateek commented 11 years ago

No problem, picky is good :)