search

square / assertj-android

A set of AssertJ helpers geared toward testing Android.
https://square.github.io/assertj-android/
Apache License 2.0
1.58k stars 156 forks source link

Moved assertions from ListViewAssert to AbstractListViewAssert. #153

Closed kriegfrj closed 9 years ago

kriegfrj commented 9 years ago

I noticed this while working on another project: These assertions look like they were in the wrong place as they won't be inherited by subclasses like ExpandableListViewAssert. If they were there for a reason feel free to reject this PR (I'm curious to know what that reason might be though).

JakeWharton commented 9 years ago

Looks like a simple oversight! Can you sign our CLA?

kriegfrj commented 9 years ago

Is there a privacy policy associated with the CLA? On 07/03/2015 5:06 am, "Jake Wharton" notifications@github.com wrote:

Looks like a simple oversight! Can you sign our CLA http://squ.re/sign-the-cla?

— Reply to this email directly or view it on GitHub https://github.com/square/assertj-android/pull/153#issuecomment-77610997 .

JakeWharton commented 9 years ago

No. It's all private, not shared.

On Fri, Mar 6, 2015 at 6:45 PM Fr Jeremy Krieg notifications@github.com wrote:

Is there a privacy policy associated with the CLA? On 07/03/2015 5:06 am, "Jake Wharton" notifications@github.com wrote:

Looks like a simple oversight! Can you sign our CLA http://squ.re/sign-the-cla?

— Reply to this email directly or view it on GitHub < https://github.com/square/assertj-android/pull/153#issuecomment-77610997> .

— Reply to this email directly or view it on GitHub https://github.com/square/assertj-android/pull/153#issuecomment-77657045 .

kriegfrj commented 9 years ago

Ok, your word is good enough for me. Done.

JakeWharton commented 9 years ago

Thanks for this!