Change custom String joiner to use framework one

square / assertj-android

A set of AssertJ helpers geared toward testing Android.

https://square.github.io/assertj-android/

Apache License 2.0

1.58k stars 156 forks source link

Change custom String joiner to use framework one #18

Closed arturdryomov closed 11 years ago

arturdryomov commented 11 years ago

There is no problem with compatibility. If it’ll be better Utils class could be removed at all.

JakeWharton commented 11 years ago

We should just inline this and replace all calls to Utils.join to TextMatcher directly. Then the class can be deleted altogether.

JakeWharton commented 11 years ago

If you use IntelliJ you can press cmd/cnrl+n on Utils.join and it will inline the method everywhere it's used. Then you can delete the Utils.java file. I'm sure Eclipse has something similar as well...

arturdryomov commented 11 years ago

Utils is dead, Jake.

JakeWharton commented 11 years ago

I'm thinking about reverting this because it means we are relying on an Android implementation for running potentially on the JVM. You could potentially use FEST Android with Mockito and not Robolectric and get failures.