square / assertj-android

A set of AssertJ helpers geared toward testing Android.
https://square.github.io/assertj-android/
Apache License 2.0
1.58k stars 156 forks source link

Update Android tools & libraries, drop support for Java 7 #218

Closed PiDelport closed 7 years ago

PiDelport commented 7 years ago

This updates the following library and build tool versions:

This also drops support for Java 7, which is no longer support by Android Plugin. (See AOSP issue 224738.)

JakeWharton commented 7 years ago

I'll merge if it passes, but just note that these aren't all the latest versions.

PiDelport commented 7 years ago

All good: I wanted to lean to the conservative side with the version updates, but I'm happy to bump them further. :)

PiDelport commented 7 years ago

Okay, versions updated to latest.

PiDelport commented 7 years ago

Hmm, the "Unsupported major.minor version 52.0" failure on Travis appears to be a Java 7 / 8 mixing thing?

PiDelport commented 7 years ago

This seems relevent: https://code.google.com/p/android/issues/detail?id=224738

According to that, "[Android Plugin] 2.2 requires Java 8".

If that's the case, it seems the choice is between dropping support for Java 7, or downgrading the Android Plugin to the latest version that still supports Java 7?

JakeWharton commented 7 years ago

You can remove JDK 7 from the build.

PiDelport commented 7 years ago

Will do. :+1:

PiDelport commented 7 years ago

Alright, does this look good?

JakeWharton commented 7 years ago

Thanks!