search

square / assertj-android

A set of AssertJ helpers geared toward testing Android.
https://square.github.io/assertj-android/
Apache License 2.0
1.58k stars 156 forks source link

Update support library to 26.0.0 #221

Closed debaj closed 7 years ago

debaj commented 7 years ago

TransportController and TransportMediator classes were removed from support-v4 26.0.0 and their functionality was replaced with MediaControllerCompat. This is a breaking change as apps using the latest support library fail to compile with assertj, even when they are not using any of the above classes.

JakeWharton commented 7 years ago

Pull requests are welcome!

On Mon, Aug 7, 2017 at 6:53 AM debaj notifications@github.com wrote:

TransportController and TransportMediator classes were removed from support-v4 26.0.0 and their functionality was replaced with MediaControllerCompat. This is a breaking change as apps using the latest support library fail to compile, even when they are not using any of the above classes.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/square/assertj-android/issues/221, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEEEeGlymIVmMZMZEUEqXbDUg8oO1vxks5sVxbdgaJpZM4Ovd8N .

debaj commented 7 years ago

PR created, please review.

jhansche commented 7 years ago

There is a workaround, albeit a hack. Simply create empty classes matching the removed classes into the src/test/java/android/support/v4/media/ directory:

package android.support.v4.media;

public class TransportController {}
package android.support.v4.media;

public class TransportMediator {}
debaj commented 7 years ago

Yeah we are doing a similar thing, we replaced the assertion class without the two missing support classes.

JakeWharton commented 7 years ago

Released as 1.2.0