square / assertj-android

A set of AssertJ helpers geared toward testing Android.
https://square.github.io/assertj-android/
Apache License 2.0
1.58k stars 156 forks source link

Use FEST Assertions 2.0M10 #39

Closed joel-costigliola closed 11 years ago

joel-costigliola commented 11 years ago

2.0M10 fixes a small incompatibility with Android as reported here.

It might be better for fest-android to depend on this version.

JakeWharton commented 11 years ago

Thanks for the heads up! Thought this was fixed by M9 but I'll upgrade and tag a new release.

joel-costigliola commented 11 years ago

No it wasn't actually ... that's why I wanted to let you know.

By the way, I was looking to your pom and notice 1.6 compilation check in maven compiler plugin. If you really want to check that your library only use 1.6 API, you should use animal sniffer plugin (funny name !) and add this to your pom :

      <plugin>
        <groupId>org.codehaus.mojo</groupId>
        <artifactId>animal-sniffer-maven-plugin</artifactId>
        <version>1.8</version>
        <configuration>
          <signature>
            <groupId>org.codehaus.mojo.signature</groupId>
            <artifactId>java16</artifactId>
            <version>1.0</version>
          </signature>
        </configuration>
        <executions>
          <execution>
            <id>Check JRE 1.6 API compatibility</id>
            <phase>test</phase>
            <goals>
              <goal>check</goal>
            </goals>
          </execution>
        </executions>
      </plugin>
JakeWharton commented 11 years ago

Released as 1.0.3. And I'll have a look at the plugin this weekend.

Thanks again.