Closed JakeWharton closed 11 years ago
BUILD SUCCESSFUL
Total time: 15.84 secs
So what happens to checkstyle?
The checkstyle plugin relies on the java plugin. Since we're using the android plugin we can't use it... Or at least I haven't found a way to use it yet.
Sorry, but...
Pull Requests that have a failing status can’t be merged from a phone.
Updated. Checkstyle is back in action.
BUILD SUCCESSFUL
Total time: 13.137 secs
@edenman @holmes ping
LGTM
I've noticed that when including...
android.libraryVariants.all { variant ->
def name = variant.buildType.name
if (name.equals(com.android.builder.BuilderConstants.DEBUG)) {
return; // Skip debug builds.
}
def task = project.tasks.create "jar${name.capitalize()}", Jar
task.dependsOn variant.javaCompile
task.from variant.javaCompile.destinationDir
artifacts.add('archives', task);
}
and
uploadArchives {
repositories {
mavenDeployer {
...
pom.project {
packaging POM_PACKAGING
...
}
}
}
}
It overrides the packaging. So if you had 'aar' as packaging it will actually remove the property and default to the 'jar' default packaging. This causes the 'aar' not getting downloaded when the dependencies are expressed somewhere else and if you use @aar in the dependency declaration then the transitive dependencies are not downloaded.
Have you guys run into this issue? If so is there a proper way to specify the deployment as packaging 'aar' and still include the jars? Thx
One packaging or the other is going to be without a pom since an artifact can only have one. Your best bet would be publishing two artifacts it would seem. We currently don't have anything set up to do this yet.
Attach a jar for non-Gradle Android users.