search

square / assertj-android

A set of AssertJ helpers geared toward testing Android.
https://square.github.io/assertj-android/
Apache License 2.0
1.58k stars 156 forks source link

AssertJ module #83

Closed aahlenst closed 10 years ago

aahlenst commented 11 years ago

Have you thought about supporting AssertJ instead of/in addition to fest-assert-2.x? fest-assert-2.x is dormant and if it comes to life again chances are it is going to be less useful (there are plans to remove a lot of assertions, see https://github.com/alexruiz/fest-assert-2.x/issues/159 and https://github.com/joel-costigliola/assertj-core#why-have-we-forked-fest-assert). I'd be willing to provide a patch, but it would be a breaking change (packages have to be renamed) and eventually involve renaming the project to assertj-android.

imminent commented 10 years ago

Related, the FEST link in the README doesn't point to a page that exists still.

f2prateek commented 10 years ago

@aahlenst I would suggest that an assertj-android project shoudl exist as a different entity, completely independent of fest-android.

aahlenst commented 10 years ago

@f2prateek I agree. Maybe even under the umbrella of the AssertJ project.

But before taking any actions I like to hear from @JakeWharton whether he's ok with it or if he/Square has other plans. Creating a fork is easy, maintaing it in the long term not so much.

JakeWharton commented 10 years ago

Can we wait until after the new year to decide? I haven't taken a long enough look to have a strong opinion yet.

avh4 commented 10 years ago

I've created https://github.com/avh4/assertj-android for my own personal use, and plan on trying to keep it up-to-date on a ~monthly basis for now until there's an official decision on what to do with this. FEST no longer seems to be being maintained, and their website no longer exists, so I've been switching all my projects to AssertJ.

aahlenst commented 10 years ago

@JakeWharton Have you made up your mind yet? Would you approve a fork?

imminent commented 10 years ago

Forks are naturally accepted. Do you mean to merge assn AssertJ back into the main library? On Mar 2, 2014 7:11 AM, "Andreas Ahlenstorf" notifications@github.com wrote:

@JakeWharton https://github.com/JakeWharton Have you made up your mind yet? Would you approve a fork?

Reply to this email directly or view it on GitHubhttps://github.com/square/fest-android/issues/83#issuecomment-36456422 .

JakeWharton commented 10 years ago

This is done on master.