square / certigo

A utility to examine and validate certificates in a variety of formats
Apache License 2.0
943 stars 70 forks source link

Tests take a dependency on an internal test certificate #258

Closed jdtw closed 2 years ago

jdtw commented 2 years ago

Tests are broken in go 1.17.7 because the internal test certificate has changed: https://cs.opensource.google/go/go/+/90860e0c3110ac5898dfe8e0e0fafd0aea8d979a.

Our tests take a dependency on these internals, which isn't ideal. We should pass in a server certificate instead of relying on the default one. We cannot simply change the tests to match the new serial/SKID without breaking compatibility with earlier Go versions.