square / cocoapods-check

A CocoaPods plugin that shows differences between locked and installed Pods
Apache License 2.0
126 stars 19 forks source link

Check if Podfile and Podfile.lock match #11

Closed jtreanor closed 4 years ago

jtreanor commented 5 years ago

Currently, if changes are made to a Podfile and pod check is run, it passes and says there is nothing to install. I think it would be better if pod check could also detect changes to the Podfile.

I have added a small check to verify if Podfile and Podfile.lock match. This makes it more similar to how bundle check works.

Do you have thoughts on this? Let me know if there are changes you think I should make.

jtreanor commented 5 years ago

I have resolved the conflicts with master. It would be great to get some thoughts on this.

mdiiorio commented 5 years ago

I'm wondering if it makes sense to display differences between the Podfile and Podfile.lock the same as the manifest differences are already displayed. For example, if you add a pod "Foo" to the Podfile and run pod check, would you expect it to tell you "Foo will be installed"? Likewise with changed and removed pods.