square / cocoapods-check

A CocoaPods plugin that shows differences between locked and installed Pods
Apache License 2.0
126 stars 19 forks source link

Adds option to ignore development pods #13

Closed ashfurrow closed 5 years ago

ashfurrow commented 5 years ago

Good morning! I'm a big fan of this library, it really speeds up our CI build times. However, I ran into a case yesterday where how it handles development pods (comparing files' last-modified times) doesn't work for our project, which integrates React Native and Objective-C code. To support our use case, I've added an --ignore-dev-pods flag that ignores development pods altogether. Thanks!

ashfurrow commented 5 years ago

Tests are passing locally:

screen shot 2019-01-11 at 10 12 16 am
allewun commented 5 years ago

I ran into the same issue and think this is a beneficial feature.

Nice work @ashfurrow, your fork works great for me!

mdiiorio commented 5 years ago

Sorry for the long delay. This seems reasonable. I'll merge it and get a release out as soon as I can.

ashfurrow commented 5 years ago

Awesome, thank you @mdiiorio! Looking forward to it.

ashfurrow commented 5 years ago

@mdiiorio good morning and happy Friday! I was just hoping I could bother you for a release to RubyGems. Have a great one!

mdiiorio commented 5 years ago

I can get that out today.

mdiiorio commented 5 years ago

I just released 1.1.0 with your change.

ashfurrow commented 5 years ago

Awesome, thanks!