square / connect-csharp-sdk

C# client library for the Square Connect APIs

https://docs.connect.squareup.com/

Apache License 2.0

27 stars 25 forks source link

Support INTERAC, and SQUARE_GIFT_CARD_V2 in V1 API #61

Closed sheam closed 6 years ago

sheam commented 6 years ago

If you are using webhooks, they will fail as .net can't deserialize the payload when the payment type is INTERAC or SQUARE_GIFT_CARD_V2.

I have been using this mod since 2.61 without issue.

sheam commented 6 years ago

Hello?

ssung88 commented 6 years ago

sheam, Thank for you reporting this issue we are looking into it. Thanks again.

bwisem commented 6 years ago

Hi Sheam,

Thanks again for reporting this. Would you mind emailing developers@help-messaging.squareup.com so we can work with you to resolve this?

Cheers!

alecholmes commented 6 years ago

Thanks for raising this issue, @sheam. We have made a change on the server so that only the values already defined in V1Tender.CardBrandEnum will be returned. We opted to make this change on the server instead of the client in order to not break users who do not upgrade their C# SDKs.

sheam commented 6 years ago

response_container_BBPPID{font-family: initial; font-size:initial; color: initial;} So how can tell if a payment is INTERAC now? What about historical payments that already had INTERAC for CardBrand? ~Shea From: notifications@github.comSent: June 13, 2018 10:52 AMTo: connect-csharp-sdk@noreply.github.comReply to: reply@reply.github.comCc: shea.martin@gmail.com; mention@noreply.github.comSubject: Re: [square/connect-csharp-sdk] Support INTERAC, and SQUARE_GIFT_CARD_V2 in V1 API (#61) Thanks for raising this issue, @sheam. We have made a change on the server so that only the values already defined in V1Tender.CardBrandEnum will be returned. We opted to make this change on the server instead of the client in order to not break users who do not upgrade their C# SDKs.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

alecholmes commented 6 years ago

Currently there is not a way to tell if a payment is Interact. They will be returned as OTHER_BRAND. However, we are working on an approach to add new values to our SDKs without breaking existing users.

sheam commented 6 years ago

response_container_BBPPID{font-family: initial; font-size:initial; color: initial;} thanks Alec, I appreciate the update.I had modified the sdk to work with the interac enum. I guess that will no longer work. I guess I can likely assume the type OTHER_BRAND is INTERAC for now. ~Shea From: notifications@github.comSent: June 13, 2018 12:08 PMTo: connect-csharp-sdk@noreply.github.comReply to: reply@reply.github.comCc: shea.martin@gmail.com; mention@noreply.github.comSubject: Re: [square/connect-csharp-sdk] Support INTERAC, and SQUARE_GIFT_CARD_V2 in V1 API (#61) Currently there is not a way to tell if a payment is Interact. They will be returned as OTHER_BRAND. However, we are working on an approach to add new values to our SDKs without breaking existing users.

—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or mute the thread.

sheam commented 5 years ago

Is this still broken? Or should I continue to use my fork?

sheam commented 5 years ago

Currently there is not a way to tell if a payment is Interact. They will be returned as OTHER_BRAND. However, we are working on an approach to add new values to our SDKs without breaking existing users.

By OTHER_BRAND do you mean CardBrandEnum.OTHERBRAND?

StephenJosey commented 5 years ago

Yes OTHER_BRAND == CardBrandEnum.OTHERBRAND. Interact payments will still be returned as OTHER_BRAND currently.