search

square / cubism

Cubism.js: A JavaScript library for time series visualization.
https://square.github.com/cubism/
Other
4.94k stars 529 forks source link

Fix more values check for librato metrics #76

Closed cyberdelia closed 1 year ago

cyberdelia commented 10 years ago

@librato seems to now return a null value rather than no key in this case, so this handle the new behaviour.

/cc @josephruscio

josephruscio commented 10 years ago

@cyberdelia thanks for the PR, @mheffner did we change this behavior?

mheffner commented 10 years ago

@cyberdelia Can you share the query you are seeing this with?

cyberdelia commented 9 years ago

@mheffner It's out of @heroku EBS cloudwatch data.

bigkevmcd commented 9 years ago

I can confirm I've also seen this issue, curiously, it seems to be intermittent.

If it helps, it reliably happens on the 10th request...or not at all...

Also, this fix could be simplified to:

var still_more_values = 'query' in data && data.query.next_time !== null;