Deprecating DataSource in favor of List

luis-cortes commented 3 years ago

Context

@helios175 and I are working on various improvements to Cycler this week as a part of hack week.

Datasource was introduced to make it easy to implement a list without forcing users to implement the full List interface. However:

DataSource and AbstractList have the exact same abstract methods
Having a DataSource wrapper has some implications in our code. It forces users to unnecessarily create a new wrapper on every invocation of toDataSource() (even when the passed in list is the same).
This is anecdotal, but any time I've used cycler I was always working with a List (or some data structure that could easily be converted to List via std lib extensions). Removing DataSource eliminates an extra step when trying to update Cycler's data.

zach-klippenstein commented 3 years ago

Could you please add a description to the PR explaining why you're making this change, linking to any relevant discussions, etc?

luis-cortes commented 3 years ago

Could you please add a description to the PR explaining why you're making this change, linking to any relevant discussions, etc?

Sorry @zach-klippenstein was getting late last night. I've updated the description with some more info.