search

square / fdoc

Documentation format and verification
Other
379 stars 59 forks source link

Refactored the presenters and cli to handle output as markdown #30

Closed rorcraft closed 11 years ago

rorcraft commented 11 years ago
zachmargolis commented 11 years ago

Hi! Thanks for adding this. I won't have time to review fully for a bit, but there are a few things you do to help out in the meantime

  1. Fix merge conflicts! Can't merge with merge conflicts
  2. Sign the Square Individual Contributor License Agreement
rorcraft commented 11 years ago
  1. Merge conflicts fixed.
  2. Signed

Let me know if you need to talk about some of the refactoring. Thanks.

zachmargolis commented 11 years ago

I just ran specs on this branch, got 2 failures in MetaServicePresenter#relative_service_path, can you take a look?

rorcraft commented 11 years ago

Are you using ruby 1.9 or 1.8 ?

zachmargolis commented 11 years ago

I use 1.9 for development, but we have clients of this project on 1.8.7, so we run CI in both to ensure compatibility. See script/ci

rorcraft commented 11 years ago

Ok, updated the hashes back to 1.8 compatible format.

rorcraft commented 11 years ago

@zachmargolis Hi, any chance of looking at this again and merge it in? Thanks.

zachmargolis commented 11 years ago

@rorcraft Yup! Thanks for the reminder. Looks good, merging.