search

square / fdoc

Documentation format and verification
Other
379 stars 59 forks source link

Require 'tmpdir' from spec helper #34

Closed harlow closed 11 years ago

harlow commented 11 years ago

http://apidock.com/ruby/Dir/mktmpdir/class

Failures:

  1) Fdoc::Cli#convert when the fdoc path does not exist raises an exception
     Failure/Error: let(:temporary_path) { Dir.mktmpdir("fdoc-cli") }
     NoMethodError:
       undefined method `mktmpdir' for Dir:Class
     # ./spec/fdoc/cli_spec.rb:5:in `block (2 levels) in <top (required)>'
     # ./spec/fdoc/cli_spec.rb:6:in `block (2 levels) in <top (required)>'
     # ./spec/fdoc/cli_spec.rb:13:in `block (2 levels) in <top (required)>'
     # ./spec/support/capture_helper.rb:6:in `capture'
     # ./spec/fdoc/cli_spec.rb:15:in `block (2 levels) in <top (required)>'
zachmargolis commented 11 years ago

Thanks!

Can you please sign the Individual Contributor License Agreement and then I'll go ahead and merge.

harlow commented 11 years ago

@zachmargolis I've submitted the license agreement -- should be all set.

zachmargolis commented 11 years ago

Thanks for signing!

Will merge. Also next time, please put cleanup changes not related to this PR on another branch (ex the lowercase yes/no changes).

harlow commented 11 years ago

Will merge. Also next time, please put cleanup changes not related to this PR on another branch (ex the lowercase yes/no changes).

@zachmargolis yeah sorry about that. I created 2 branches and 2 PRs from my forked repo (https://github.com/harlow/fdoc/branches) not sure why these would have come over in one PR.