square / in-app-payments-react-native-plugin

Apache License 2.0
116 stars 49 forks source link

feat: add Expo config plugin #193

Open fobos531 opened 1 year ago

fobos531 commented 1 year ago

Summary

This PR adds support for automatically configuring the native Android/iOS (required for enabling Google/Apple Pay) projects using Expo's config plugins for users that use Expo.

Changelog

Test Plan

N/A

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

charmiswebiots commented 1 year ago

@fobos531 EXPO is a framework built on top of react native and it’s officially supported by react native. It’s great if this change works. Can you please verify if that PR works with EXPO and not breaking the current quick start app? if so, you can approve and merge PR, then we can enable our plugin with EXPO.

kuldip-simform commented 11 months ago

Any update on this PR?

JoshKeenan commented 4 months ago

Any movement on this at all?

JoshKeenan commented 4 months ago

Pretty sure that it isn't able to associate with any podspec at present and will fail in a build as the build phase this particular line is returning anything in the prebuild phase.

const podspecs = glob.sync('{ios/**/,}*.podspec');

This returns undefined implying that there is no podspec associated with the config plugin itself for iOS which is a requirement.

danrivett commented 4 months ago

We're also looking to integrate Square into our existing Production Expo app (SDK 50).

We were about to start implementing stories to add support after seeing the React Native blog post but a customary search found this PR as well as #208, so it looks like it's not possible.

Looks like Stripe is the only processor I can find that documents support for Expo, but I'd love to be proven wrong since we already use Square in other parts of our organisation, so we were hoping to use it in our Expo app too.

kuldip-simform commented 3 months ago

Please check this thread: https://github.com/square/in-app-payments-react-native-plugin/issues/236#issuecomment-2071933733

it will give you some insight for future problem due to adding build script in iOS which I have solved.

timmyjose commented 1 week ago

Any updates on this?