kuldip-simform
commented
5 months ago The issue was from my side I forgot to add build phase which is mentioned here in iOS SDK documentation.
But as I am using Expo and there is no plugins provided by Square, I have to create my own to add merchantIds in xcode and enable google pay in android side.also I had to create plugin to add build phase in xcode project build phase. Now issue arise due to order of build phase.
All the plugins run before pod install in expo and after pod install [CP] Embed Pods Frameworks script gets added. whereas square script needs to last.
So I had to right ruby script to re-order build script to be last and run this script in eas-build-post-install script. so this will be run after pod-install is done.
Re-ordering build phase script
#!/usr/bin/env ruby
require 'xcodeproj'
require 'set'
project_file, target_name = ARGV
puts "Sorting sources in #{project_file} for target #{target_name}"
project = Xcodeproj::Project.open(project_file)
target = project.targets.select { |t| t.name == target_name }.first
square_framework_run_script_index = target.build_phases.index { |b|
name = b.name if b.respond_to? :name
name == "Square Framework Run Script - InAppPaymentsSDK" #name of build phase you have given in plugin below
}
puts "Square Framework Run Script index: #{square_framework_run_script_index} Total build phases: #{target.build_phases.count - 1}"
if square_framework_run_script_index.nil? == false
puts "Moving Square Framework Run Script from #{square_framework_run_script_index} to the #{target.build_phases.count - 1} index"
target.build_phases.move_from(square_framework_run_script_index, target.build_phases.count - 1) # move to the last indexs
end
project.savePlugin for adding script in Xcode
const { withXcodeProject } = require('@expo/config-plugins');
const addBuildPhaseForSquareIOS = (config) => {
return withXcodeProject(config, async (conf) => {
const project = conf.modResults;
project.addBuildPhase(
[],
'PBXShellScriptBuildPhase',
'Square Framework Run Script - InAppPaymentsSDK', // build phase name
project.getFirstTarget().uuid,
{
shellPath: '/bin/sh',
shellScript:
'FRAMEWORKS="${BUILT_PRODUCTS_DIR}/${FRAMEWORKS_FOLDER_PATH}" && "${FRAMEWORKS}/SquareInAppPaymentsSDK.framework/setup"',
},
);
return conf;
});
};
module.exports = addBuildPhaseForSquareIOS;
Add this plugin in app.json or app.config.ts.
like this
{
"expo": {
...,
plugins: [
...,
[
"./appleGooglePayConfigPlugin.js",
{
"merchantIdentifier": "your merchant id",
"enableGooglePay": true
}
],
[
"./squareIOSBuildPhasePlugin.js"
],
],
}
}script file for adding that to package.json like: "eas-build-post-install": "./eas-hooks/eas-build-post-install.sh"
#!/usr/bin/env bash
# This is a file called "pre-install" in the root of the project
if [[ "$EAS_BUILD_PLATFORM" == "ios" ]]; then
./reorderSquareIAPBuildPhase.rb ios/your_project_name.xcodeproj your_target_name
fi
I have also written another plugin for adding merchantsId and google pay to true.
const {
AndroidConfig,
ConfigPlugin,
IOSConfig,
withAndroidManifest,
withEntitlementsPlist,
} = require('@expo/config-plugins');
const { addMetaDataItemToMainApplication, getMainApplicationOrThrow, removeMetaDataItemFromMainApplication } =
AndroidConfig.Manifest;
// type SquarePluginProps = {
// /**
// * The iOS merchant ID used for enabling Apple Pay.
// * Without this, the error "Missing merchant identifier" will be thrown on iOS.
// */
// merchantIdentifier: string | string[];
// enableGooglePay: boolean;
// };
const withSquareIos = (expoConfig, { merchantIdentifier }) => {
return withEntitlementsPlist(expoConfig, (config) => {
config.modResults = setApplePayEntitlement(merchantIdentifier, config.modResults);
return config;
});
};
const withSquare = (config, props) => {
config = withSquareIos(config, props);
config = withNoopSwiftFile(config);
config = withSquareAndroid(config, props);
return config;
};
/**
* Adds the following to the entitlements:
*
* <key>com.apple.developer.in-app-payments</key>
* <array>
* <string>[MERCHANT_IDENTIFIER]</string>
* </array>
*/
function setApplePayEntitlement(merchantIdentifiers, entitlements) {
const key = 'com.apple.developer.in-app-payments';
// eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
const merchants = entitlements[key] ?? [];
if (!Array.isArray(merchantIdentifiers)) {
merchantIdentifiers = [merchantIdentifiers];
}
for (const id of merchantIdentifiers) {
if (id && !merchants.includes(id)) {
merchants.push(id);
}
}
if (merchants.length) {
entitlements[key] = merchants;
}
return entitlements;
}
/**
* Add a blank Swift file to the Xcode project for Swift compatibility.
*/
const withNoopSwiftFile = (config) => {
return IOSConfig.XcodeProjectFile.withBuildSourceFile(config, {
filePath: 'noop-file.swift',
contents: [
'//',
'// @generated',
'// A blank Swift file must be created for native modules with Swift files to work correctly.',
'//',
'',
].join('\n'),
});
};
const withSquareAndroid = (expoConfig, { enableGooglePay = false }) => {
return withAndroidManifest(expoConfig, (config) => {
config.modResults = setGooglePayMetaData(enableGooglePay, config.modResults);
return config;
});
};
/**
* Adds the following to AndroidManifest.xml:
*
* <application>
* ...
* <meta-data
* android:name="com.google.android.gms.wallet.api.enabled"
* android:value="true|false" />
* </application>
*/
function setGooglePayMetaData(enabled, modResults) {
const GOOGLE_PAY_META_NAME = 'com.google.android.gms.wallet.api.enabled';
const mainApplication = getMainApplicationOrThrow(modResults);
if (enabled) {
addMetaDataItemToMainApplication(mainApplication, GOOGLE_PAY_META_NAME, 'true');
} else {
removeMetaDataItemFromMainApplication(mainApplication, GOOGLE_PAY_META_NAME);
}
return modResults;
}
module.exports = withSquare;
timmyjose
SeanBarker182
Describe the issue
I have updated to new version
1.7.4from1.7.2. After that When I open app, app immediately crashes on both real device and simulatorHere is the log:
To Reproduce
Steps to reproduce the issue.
For example -
Expected behavior
app should run without any issue.
Environment (please complete the following information):
Screenshots
https://github.com/square/in-app-payments-react-native-plugin/assets/104821076/bd969b21-f3c9-4216-a644-42ae2942e4d9