search

square / jna-gmp

A Java JNA wrapper around the GNU Multiple Precision Arithmetic Library.
Apache License 2.0
62 stars 24 forks source link

Added support for Solaris 10/SmartOS/Illumos x86-64 support. #5

Closed dekobon closed 8 years ago

dekobon commented 8 years ago

I've added support for a Solaris 10 compatible binary. I compiled and tested on SmartOS. The other change is that I removed the global else statement in the Makefile, such that if the OS is not recognized it fails.

JakeWharton commented 8 years ago

Hi @dekobon. Can you please sign the CLA so that, assuming the changes are approved, we can merge?

dekobon commented 8 years ago

Hi @JakeWharton,

I've signed the CLA. Please merge anytime you like. Thanks!

dekobon commented 8 years ago

@JakeWharton Can I help with any work needed to merge this PR?

JakeWharton commented 8 years ago

@jhump or @dragonsinth would have to help there. I'm just the human version of a CLA checking robot :cry:

dragonsinth commented 8 years ago

Hi @dekobon, thanks for the contribution. The Makefile changes LGTM.

However.. I'm really unsure about how to proceed with accepting a binary submission. I don't doubt that it's legit, but I have no way to verify it. Are there any public OS images I could run on GCE to compile the binary myself?

dekobon commented 8 years ago

Hi @dragonsinth ,

I can provide you a host on the Joyent public cloud. Please email with your prefered email address and send me your public key. My email is elijah.zupancic@joyent.com

dragonsinth commented 8 years ago

This is now merged, thanks @dekobon. I built the binary, ran the tests, and committed to master. I did need to make a small Makefile tweak, but no biggie.

dekobon commented 8 years ago

@JakeWharton - I hear that you were the person to ask about getting a release pushed to Maven Central. Is there any chance you can help to make that happen?

JakeWharton commented 8 years ago

Yep. I'll do it later tonight.

On Sat, Mar 5, 2016 at 2:28 PM Elijah Zupancic notifications@github.com wrote:

@JakeWharton https://github.com/JakeWharton - I hear that you were the person to ask about getting a release pushed to Maven Central. Is there any chance you can help to make that happen?

— Reply to this email directly or view it on GitHub https://github.com/square/jna-gmp/pull/5#issuecomment-192713089.

JakeWharton commented 8 years ago

Released as 1.1.0.

On Sat, Mar 5, 2016 at 2:44 PM Jake Wharton jakewharton@gmail.com wrote:

Yep. I'll do it later tonight.

On Sat, Mar 5, 2016 at 2:28 PM Elijah Zupancic notifications@github.com wrote:

@JakeWharton https://github.com/JakeWharton - I hear that you were the person to ask about getting a release pushed to Maven Central. Is there any chance you can help to make that happen?

— Reply to this email directly or view it on GitHub https://github.com/square/jna-gmp/pull/5#issuecomment-192713089.