No outline on focus-visible tabbing on Text Button - Githubissues

square / maker

Maker Design System by Square

https://square.github.io/maker/styleguide/latest-stable/

Other

63 stars 14 forks source link

No outline on focus-visible tabbing on Text Button #254

Closed kevinlee11 closed 2 years ago

kevinlee11 commented 2 years ago

Bug description

If you tab into a Text Button (:focus-visible) you don't get the accessibility outline colour because of the outline being set to none.

Expected without that property:

Reproduction

Tab into the Text Button and you won't get the accessibility outline colour.

Environment

System:
    OS: macOS 11.6.4
    CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 1.80 GB / 64.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 12.16.2 - ~/.nvm/versions/node/v12.16.2/bin/node
    npm: 6.14.4 - ~/.nvm/versions/node/v12.16.2/bin/npm
  npmPackages:
    @square/maker: ^7.0.0 => 7.0.0 
    vue: ^2.6.14 => 2.6.14 
    webpack: ^5.37.0 => 5.38.1

Addressed by

No response

Can you contribute a fix?

[ ] I’m interested in opening a pull request for this issue.

pretzelhammer commented 2 years ago

closing, pr was merged